Add new --platform flag #2045
Merged
Add new --platform flag #2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new flag allowing you to set what the expected value of sys.platform is for this particular run. It is similar to the --python-version flag, which lets you control what the expected value of sys.version_info for this run is.
Previously, mypy only took into account sys.platform of the form `sys.platform == ???` or `sys.platform != ???`. This adds support for `sys.platform.startswith(???)` checks. This will probably be helpful when writing Python2/Python3-straddling code. For example, Python 2, sys.platform returns 'linux2' on Linux systems, but in Python 3, sys.platform will return just 'linux'.
This commit modifies the test suite to allow test cases to set custom values for the python-version and os-platform flags.
|
(This seemed like a useful thing to have implemented before the next Mypy release, mostly for the sake of completeness, so I just went ahead and did it. I'm also not sure if |
|
What if we'd call it |
|
Either `--platform` or `--sys-platform` works for me, but I had always
assumed I'd call it `--platform`. Thanks for implementing this!
|
|
Alright, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements #1988 by adding a new
--platformflag to allow the user to typecheck code specific to a particular operating system without having to actually run mypy on that OS.It also modifies the test suite by adding
# pyversion: ...and# platform: ...flags to let test suites pick and chose exactly which Python version/OS platform they should run under.It also adds supports for checks of the form
if sys.platform.startswith(...). I added this check mainly because the Python docs seem to explicitly recommend using thestartswithidiom over direct comparison.